This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFAv2] (Ada) Add gdb-mi support for stopping at start of exception handler.


> From: Xavier Roirand <roirand@adacore.com>
> Cc: Xavier Roirand <roirand@adacore.com>,	simon.marchi@ericsson.com,	brobecker@adacore.com
> Date: Mon,  8 Jan 2018 10:14:38 +0100
> 
> Following my previous commit which add support for stopping at start of
> exception handler, this commit adds required gdb-mi support for this
> feature.
> 
> gdb/ChangeLog:
> 
>         * ada-lang.c (catch_ada_exception_command_split,
>         create_ada_exception_catchpoint, catch_ada_assert_command_split)
>         <cond_string>: Change parameter type.  Update code accordingly.
>         Update callers.
>         (catch_ada_exception_command, catch_ada_handlers_command,
>         catch_assert_command): Use std::string instead of char*.
>         * ada-lang.h (create_ada_exception_catchpoint) <cond_string>:
>         Update declaration.
>         * mi/mi-cmd-catch.c (mi_cmd_catch_assert): Use std::string
>         instead of char* for condition string.
>         (mi_cmd_catch_exception): Use std::string instead of char* for
>         condition string.  Remove uneeded xstrdup.
>         (mi_cmd_catch_handlers): New function for -catch-handlers command.
>         * mi/mi-cmds.c (struct mi_cmds): Add catch-handlers command.
>         * mi/mi-cmds.h (mi_cmd_catch_handlers): Add external declaration.
>         * NEWS: Document "-catch-handlers" command.
> 
> gdb/doc/ChangeLog:
> 
>         * gdb.texinfo (Ada Exception gdb/mi Catchpoints): Add
>         documentation for new "-catch-handlers" command.
> 
> gdb/testsuite/ChangeLog:
> 
>         * gdb.ada/mi_catch_ex_hand.exp: New testcase.
>         * gdb.ada/mi_catch_ex_hand/foo.adb: New file.

The documentation parts of this patch are approved, with this single
comment:

> +@subsubheading @value{GDBN} Command
> +
> +The corresponding @value{GDBN} command is @samp{catch handlers}.

Please add here a cross-reference to where "catch handlers" is
described.

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]