This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 3/6] Allocate dwarf2_cu with new

From: Yao Qi <qiyaoltc at gmail dot com>
To: Tom Tromey <tom at tromey dot com>
Cc: gdb-patches at sourceware dot org
Date: Wed, 10 Jan 2018 12:17:24 +0000
Subject: Re: [RFA 3/6] Allocate dwarf2_cu with new
Authentication-results: sourceware.org; auth=none
References: <20180106002621.21099-1-tom@tromey.com> <20180106002621.21099-4-tom@tromey.com>

Tom Tromey <tom@tromey.com> writes:

>  /* Internal state when decoding a particular compilation unit.  */
>  struct dwarf2_cu
>  {
> +  dwarf2_cu (struct dwarf2_per_cu_data *per_cu);

Add "explicit"?

> +  ~dwarf2_cu ();
> +
> +  DISABLE_COPY_AND_ASSIGN (dwarf2_cu);
> +
> +  void free_abbrev_table ();

Move comments to dwarf2_free_abbrev_table here?

-- 
Yao (齐尧)

Follow-Ups:
- Re: [RFA 3/6] Allocate dwarf2_cu with new
  - From: Tom Tromey

References:
- [RFA 0/6] Some DWARF reader polishing
  - From: Tom Tromey
- [RFA 3/6] Allocate dwarf2_cu with new
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]