This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/7] Class-fy partial_die_info
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 25 Jan 2018 16:05:24 +0400
- Subject: Re: [PATCH 0/7] Class-fy partial_die_info
- Authentication-results: sourceware.org; auth=none
- References: <1516873114-7449-1-git-send-email-yao.qi@linaro.org>
Hi Yao,
On Thu, Jan 25, 2018 at 09:38:27AM +0000, Yao Qi wrote:
> When I fix some issue related to dwarf, I class-fy partial_die_info as
> part of the fix. The class-fy bits can go upstream first.
>
> Regression tested on x86_64-linux.
>
> *** BLURB HERE ***
>
> Yao Qi (7):
> Re-write partial_die_info allocation in load_partial_dies
> Don't check abbrev is NULL in read_partial_die
> Change find_partial_die_in_comp_unit to dwarf2_cu::find_partial_die
> Class-fy partial_die_info
> Remove one argument abbrev_len in read_partial_die
> Move fixup_partial_die to partial_die_info::fixup
> Move read_partial_die to partial_die_info::read
>
> gdb/dwarf2read.c | 339 ++++++++++++++++++++++++++++++-------------------------
> 1 file changed, 185 insertions(+), 154 deletions(-)
What's the advantage of turning this struct into a class?
Is it memory management?
(sorry if it's obvious from the code - C++ dummy, here)
--
Joel