This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/RFC] Clarify contents of NEWS entry re: Python "rbreak" (waa: "Re: [python][patch] Python rbreak")
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>, Eli Zaretskii <eliz at gnu dot org>
- Cc: Simon Marchi <simon dot marchi at polymtl dot ca>, gdb-patches at sourceware dot org
- Date: Thu, 1 Feb 2018 10:26:16 +0000
- Subject: Re: [RFA/RFC] Clarify contents of NEWS entry re: Python "rbreak" (waa: "Re: [python][patch] Python rbreak")
- Authentication-results: sourceware.org; auth=none
- References: <f39f6365-fc45-ea7d-10dc-5e0053db5cbb@redhat.com> <e3c7c9b4-131a-f237-6392-766a65c336f9@ericsson.com> <5e1ba7e3-5f6e-2478-30a5-7670ec7a9879@redhat.com> <3193f5c7a0c98c548722bb6c143f347e@polymtl.ca> <8ee8a4c0-4580-474f-a5aa-6f76a8d22960@redhat.com> <ca375e73-57a2-88a7-f188-740a45e3a375@redhat.com> <20180201094559.zfqwrjixo3iuc7f2@adacore.com>
On 01/02/18 09:45, Joel Brobecker wrote:
> [hi Eli -- not sure if the attached patch is obvious or not, so I will
> wait for your approval, assuming Phil confirms. Thank you!]
>
> Hi Phil,
>
> Can you clarify something for me?
>
>>> diff --git a/gdb/NEWS b/gdb/NEWS
>>> index 2bad096a86..1d26ea4af7 100644
>>> --- a/gdb/NEWS
>>> +++ b/gdb/NEWS
>>> @@ -24,6 +24,10 @@
>>> gdb.new_thread are emitted. See the manual for further
>>> description of these.
>>>
>>> + ** A new command, "rbreak" has been added to the Python API. This
>>> + command allows the setting of a large number of breakpoints via a
>>> + regex pattern in Python. See the manual for further details.
>
> Based on the implementation, I'm pretty sure that it's actualy a new
> function, rather than a new command; is that correct?
>
> If I am, I would like to suggest the following change to the NEWS file,
> to make it clearer.
It's a Python implementation of rbreak. I thought about making prbreak
as a Python implementation of a GDB command but decided to leave it as
an API call instead. However you want to word it is totally
fine. Sorry for any confusion introduced!
Cheers
Phil