This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Move arch/tdesc.h to common/common-tdesc.h
- From: Alan Hayward <Alan dot Hayward at arm dot com>
- To: Philipp Rudo <prudo at linux dot vnet dot ibm dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, nd <nd at arm dot com>
- Date: Thu, 1 Feb 2018 13:19:47 +0000
- Subject: Re: [PATCH] Move arch/tdesc.h to common/common-tdesc.h
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan dot Hayward at arm dot com;
- Nodisclaimer: True
- References: <97948063-b3db-fd3a-f62e-b552935cb8dd@arm.com> <20180201121443.43322674@ThinkPad>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
> On 1 Feb 2018, at 11:14, Philipp Rudo <prudo@linux.vnet.ibm.com> wrote:
>
> Hi Alan,
>
> the patch looks good to me.
>
> If it were for me, I would drop the extra 'common-' and call the file
> just common/tdesc.h …
>
> On Wed, 31 Jan 2018 13:40:04 +0000
> Alan Hayward <alan.hayward@arm.com> wrote:
>
>> Following on from review comments for:
>> [PATCH v2 5/8] Use tdesc types in gdbserver tdesc
>>
>> This patch simply moves arch/tdesc.h to common/tdesc.h.
>
> ... like stated here. But that's just my taste. When looking at the git log in
> common/ I don't see any clear pattern for the current best practice in naming
> the files.
>
That results in common/tdesc.h and gdbserver/tdesc.h
That’s not a problem by itself, because we can just prefix the dir
name as part of the include.
My next set of patches will then add common/tdesc.c.
This is slightly more tricky because we now build two tdesc.o files.
The gdbserver IPA rules will need tweaking, and I’m not sure the OBS
list will work as it is (given it doesn’t have any dir names).
Like you, I wasn’t sure if there was a naming convention for common/.
In the end I went with the easiest solution :)
Thanks for reviewing!
Alan.