This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Check for ncursesw first when searching for "tgetent"
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: GDB Patches <gdb-patches at sourceware dot org>
- Cc: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Date: Fri, 09 Feb 2018 20:43:37 -0500
- Subject: Re: [PATCH] Check for ncursesw first when searching for "tgetent"
- Authentication-results: sourceware.org; auth=none
- References: <20180131210430.23787-1-sergiodj@redhat.com>
On Wednesday, January 31 2018, I wrote:
> Commit 5007d765ae09c10c7f3b18bb16841b9d2d59e181 ("Allow linking GDB
> with ncursesw") modified our configure.ac and included the check for
> "ncursesw" when searching for "waddstr". However, there's one more
> place where we should check for "ncursesw" first:
>
> AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncursesw ncurses])
>
> This patch changes the order of the libraries to be searched when
> looking for "tgetent", and puts "ncursesw" before "curses ...".
>
> This is another patch we carry on Fedora GDB.
Ping.
> gdb/ChangeLog:
> 2018-01-31 Sergio Durigan Junior <sergiodj@redhat.com>
>
> * configure.ac: Check for "ncursesw" first when searching for
> "tgetent".
> * configure: Regenerate.
> ---
> gdb/configure | 2 +-
> gdb/configure.ac | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/configure b/gdb/configure
> index 81b35af521..c552c1ab1f 100755
> --- a/gdb/configure
> +++ b/gdb/configure
> @@ -8912,7 +8912,7 @@ return tgetent ();
> return 0;
> }
> _ACEOF
> -for ac_lib in '' termcap tinfo curses ncursesw ncurses; do
> +for ac_lib in '' termcap tinfo ncursesw curses ncurses; do
> if test -z "$ac_lib"; then
> ac_res="none required"
> else
> diff --git a/gdb/configure.ac b/gdb/configure.ac
> index 125e5f30e6..a73f72d0a8 100644
> --- a/gdb/configure.ac
> +++ b/gdb/configure.ac
> @@ -609,7 +609,7 @@ case $host_os in
> esac
>
> # These are the libraries checked by Readline.
> -AC_SEARCH_LIBS(tgetent, [termcap tinfo curses ncursesw ncurses])
> +AC_SEARCH_LIBS(tgetent, [termcap tinfo ncursesw curses ncurses])
>
> if test "$ac_cv_search_tgetent" = no; then
> CONFIG_OBS="$CONFIG_OBS stub-termcap.o"
> --
> 2.14.3
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/