This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 1/3] Initial support for variant parts


>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> For people like me, a small comment explaining that signed discriminant
Joel> values are also handled despite the use of an unsigned type thanks to
Joel> proper sign extension might avoid some confusion. Would it be OK to
Joel> add something like this?

Sure, I put a comment in value_union_variant where the discriminant is
computed.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]