This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA/doco] set varsize-limit: New GDB setting for maximum dynamic object size
> Date: Fri, 23 Feb 2018 08:59:14 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
>
> Sometimes, I wonder what we would do without your help!
Thanks.
> > > + add_setshow_uinteger_cmd ("varsize-limit", class_support,
> > > + &varsize_limit, _("\
> > > +Set the maximum number of bytes allowed in a dynamic-sized object."), _("\
> > > +Show the maximum number of bytes allowed in a dynamic-sized object."), _("\
> > > +Attempts to access an object whose size is not a compile-time constant\n\
> > > +and exceeds this limit will cause an error."),
> >
> > This is okay, but I wonder if "varsize" is a good name. The
> > explanatory text you've written doesn't talk of any "variables".
>
> It was before my time (so more than 15 years ago!), but I think that
> "var" (for variable) is the adjective, rather than the noun.
Then I suggest to use "variable-size objects" instead of
"dynamic-sized objects" in the doc string, and probably also in the
manual.
Otherwise, the new version of the patch is fine in the documentation
parts.