This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Remove most cleanups from linux-thread-db.c
- From: Tom Tromey <tom at tromey dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Sun, 25 Feb 2018 11:00:34 -0700
- Subject: Re: [RFA] Remove most cleanups from linux-thread-db.c
- Authentication-results: sourceware.org; auth=none
- References: <20180222170248.27265-1-tom@tromey.com> <3e9c00376fafb2a9df13bbd1ea855a86@polymtl.ca>
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> On 2018-02-22 12:02, Tom Tromey wrote:
>> The remaining cleanup in linux-thread-db.c uses
>> make_cleanup_free_char_ptr_vec, which requires a somewhat bigger
>> change.
Simon> I had a patch for that lying around, so I posted it along with other
Simon> cleanup patches to get rid of free_char_ptr_vec here, if you want to
Simon> take a look:
Simon> https://sourceware.org/ml/gdb-patches/2018-02/msg00355.html
I skimmed this series and it looked good to me.
I definitely like the idea and I thought the particular decisions you
made, about when to use string or unique_xmalloc_ptr, made sense.
Tom