Re: [PATCH] Update documentation for get_args

[Simon Marchi <simark at simark dot ca>]

On 2018-02-22 05:46 PM, Keith Seitz wrote:
> --- a/gdb/compile/compile.c
> +++ b/gdb/compile/compile.c
> @@ -393,9 +393,25 @@ filter_args (int *argcp, char **argv)
>    *destv = NULL;
>  }
>  
> -/* Produce final vector of GCC compilation options.  First element is target
> -   size ("-m64", "-m32" etc.), optionally followed by DW_AT_producer options
> -   and then compile-args string GDB variable.  */
> +/* Produce final vector of GCC compilation options.
> +
> +   The first element of the combined argument vector are arguments
> +   relating to the target size ("-m64", "-m32" etc.). These are
> +   sourced from the inferior's architecture.
> +
> +   The second element of the combined argument vector are arguments
> +   stored in the inferior DW_AT_producer section.  If these are stored
> +   in the inferior (there is no guarantee that they are), they are
> +   added to the vector.
> +
> +   The third element of the combined argument vector are argument
> +   supplied by the language implementation provided by
> +   compile-{lang}-support. These contain language specific arguments.
> +
> +   The final element of the combined argument vector are arguments
> +   supplied by the "set compiler-args" command. These are always

"set compile-args", and two spaces after period (a few occurences in the patch).

Otherwise, LGTM, the comment seems to match the implementation.

Thanks!

Simon