This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/7 v2] Class-fy partial_die_info
- From: Simon Marchi <simark at simark dot ca>
- To: Yao Qi <qiyaoltc at GMAIL dot COM>, gdb-patches at sourceware dot org
- Date: Sun, 25 Feb 2018 18:52:34 -0500
- Subject: Re: [PATCH 0/7 v2] Class-fy partial_die_info
- Authentication-results: sourceware.org; auth=none
- References: <1519313796-2397-1-git-send-email-yao.qi@linaro.org>
On 2018-02-22 10:36 AM, Yao Qi wrote:
> When I fix some issues related to dwarf, I class-fy partial_die_info as
> part of the fix. The class-fication bits can go upstream first.
>
> This is the v2 of this patch series, v1 can be found
> https://sourceware.org/ml/gdb-patches/2018-01/msg00505.html Changes
> in v2 are,
>
> - Don't move the location of partial_die_info::fixup_called, as it may
> increase the memory usage,
> - Add some comments to read_partial_die,
>
> *** BLURB HERE ***
>
> Yao Qi (7):
> Re-write partial_die_info allocation in load_partial_dies
> Don't check abbrev is NULL in read_partial_die
> Change find_partial_die_in_comp_unit to dwarf2_cu::find_partial_die
> Class-fy partial_die_info
> Remove one argument abbrev_len in read_partial_die
> Move fixup_partial_die to partial_die_info::fixup
> Move read_partial_die to partial_die_info::read
>
> gdb/dwarf2read.c | 337 ++++++++++++++++++++++++++++++-------------------------
> 1 file changed, 183 insertions(+), 154 deletions(-)
>
I went through the series again, I sent a comment on patch 2,
otherwise LGTM.
Simon