This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Workaround a FreeBSD ptrace() bug with clearing thread events.


Hi John,

> gdb/ChangeLog:
> 
> 	* fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
> 	wildcard process pid for super_resume for kernels with a
> 	specific bug.

Just a small coding style nit:

> +#if __FreeBSD_version < 1200052
> +  /*
> +   * When multiple threads within a process wish to report STOPPED
> +   * events from wait(), the kernel picks one thread event as the

In the GDB project, we do not use the '*' at the start of every line.
See:

https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Block_Comment_Formatting

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]