This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA v2 4/4] Handle DW_TAG_variant_part and DW_TAG_variant
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 26 Feb 2018 10:56:20 +0400
- Subject: Re: [RFA v2 4/4] Handle DW_TAG_variant_part and DW_TAG_variant
- Authentication-results: sourceware.org; auth=none
- References: <20180222203018.23551-1-tom@tromey.com> <20180222203018.23551-5-tom@tromey.com>
> 2018-02-22 Tom Tromey <tom@tromey.com>
>
> * dwarf2read.c (struct variant_field): New.
> (struct nextfield) <variant>: New field.
> (dwarf2_add_field): Handle DW_TAG_variant_part.
> (dwarf2_attach_fields_to_type): Attach a discriminant_info to a
> discriminated union.
> (read_structure_type): Handle DW_TAG_variant_part.
> (handle_struct_member_die): New function, extracted from
> process_structure_scope. Handle DW_TAG_variant.
> (process_structure_scope): Handle discriminated unions. Call
> handle_struct_member_die.
>
> 2018-02-22 Tom Tromey <tom@tromey.com>
>
> * gdb.dwarf2/variant.c: New file.
> * gdb.dwarf2/variant.exp: New file.
Looks good to me, Tom. Thanks!
--
Joel