This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Improve gcore shell quoting and portability
- From: Georg Sauthoff <mail at georg dot so>
- To: Simon Marchi <simark at simark dot ca>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 1 Mar 2018 20:48:03 +0100
- Subject: Re: [PATCH] Improve gcore shell quoting and portability
- Authentication-results: sourceware.org; auth=none
- References: <20180225204601.19068-1-mail@georg.so> <6c710a6d-5d12-c2eb-4c11-9c28196f3866@simark.ca>
On Sun, Feb 25, 2018 at 05:41:40PM -0500, Simon Marchi wrote:
Hello,
[..]
> > # `</dev/null' to avoid touching interactive terminal if it is
> > # available but not accessible as GDB would get stopped on SIGTTIN.
> > - $binary_path/@GDB_TRANSFORM_NAME@ </dev/null --nx --batch \
> > + "$binary_path"/@GDB_TRANSFORM_NAME@ </dev/null --nx --batch \
> To be pedantic, I guess we would have to quote the whole path, since
> GDB_TRANSFORM_NAME could contain some spaces. It's not very likely, I agree,
> but it's also easy to change.
> If you are fine with the suggestions above, I could fix them and push the resulting
> patch, is that ok with you?
yes, I'm fine with all your suggestion.
I'm also a fan of the `#!/usr/bin/env someinterpreter` construct.
Thus, please go ahead.
Best regards
Georg