This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Conditionally include "<windows.h>" on common/pathstuff.c (and unbreak build on mingw*)
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Simon Marchi <simon dot marchi at ericsson dot com>, Pedro Alves <palves at redhat dot com>, Joel Brobecker <brobecker at adacore dot com>, Christophe Lyon <christophe dot lyon at linaro dot org>
- Date: Fri, 02 Mar 2018 11:11:04 +0000
- Subject: Re: [PATCH] Conditionally include "<windows.h>" on common/pathstuff.c (and unbreak build on mingw*)
- Authentication-results: sourceware.org; auth=none
- References: <CAKdteOYtFqn-4Bvd2Tekjpf+h5D-8dTSLKSPXcC7YAMRrJ1TCw@mail.gmail.com> <20180301202005.11563-1-sergiodj@redhat.com>
Sergio Durigan Junior <sergiodj@redhat.com> writes:
> Introduced a regression when compiling for mingw*:
>
> /gdb/common/pathstuff.c: In function 'gdb::unique_xmalloc_ptr<char>
> gdb_realpath(const char*)':
> /gdb/common/pathstuff.c:56:14: error: 'MAX_PATH' was not declared in this scope
> char buf[MAX_PATH];
Fedora-x86_64-w64-mingw32 catches this build failure
https://gdb-build.sergiodj.net/builders/Fedora-x86_64-w64-mingw32/builds/1113/steps/compile%20gdb/logs/stdio
but it doesn't send notification on build failure. Could you change the
buildbot config to send notification on build failure? The same as
other builders do.
--
Yao (齐尧)