This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/3] Add a new debug knob for the FreeBSD native target.
- From: Pedro Alves <palves at redhat dot com>
- To: John Baldwin <jhb at FreeBSD dot org>, gdb-patches at sourceware dot org
- Date: Fri, 2 Mar 2018 20:19:33 +0000
- Subject: Re: [PATCH 2/3] Add a new debug knob for the FreeBSD native target.
- Authentication-results: sourceware.org; auth=none
- References: <20180228014656.32372-1-jhb@FreeBSD.org> <20180228014656.32372-3-jhb@FreeBSD.org>
LGTM, but one small question below.
On 02/28/2018 01:46 AM, John Baldwin wrote:
> @@ -765,6 +765,7 @@ fbsd_xfer_partial (struct target_ops *ops, enum target_object object,
>
> #ifdef PT_LWPINFO
> static int debug_fbsd_lwp;
> +static int debug_fbsd_nat;
Should this be guarded by PT_LWPINFO? Wouldn't you want to
enable fbsd-nat debugging on FreeBSD systems without PT_LWPINFO?
(Hmm, does GDB actually build today if PT_LWPINFO is not defined?)
Thanks,
Pedro Alves