This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Use gdb::byte_vector when reading section data
- From: Simon Marchi <simark at simark dot ca>
- To: Joel Brobecker <brobecker at adacore dot com>, Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sun, 11 Mar 2018 12:07:24 -0400
- Subject: Re: [RFA] Use gdb::byte_vector when reading section data
- Authentication-results: sourceware.org; auth=none
- References: <20180309183349.18352-1-tom@tromey.com> <20180311141112.lyiwlb3hmfv6voeb@adacore.com>
On 2018-03-11 10:11 AM, Joel Brobecker wrote:
>> This changes a couple of spots that read section data to use
>> gdb::byte_vector rather than a cleanup.
>>
>> Regression tested by the buildbot. I am not certain that the buildbot
>> actually tests the code in question, so I recommend careful review.
>>
>> gdb/ChangeLog
>> 2018-03-09 Tom Tromey <tom@tromey.com>
>>
>> * rs6000-aix-tdep.c (rs6000_aix_core_xfer_shared_libraries_aix):
>> Use gdb::byte_vector.
>> * arm-tdep.c (arm_exidx_new_objfile): Use gdb::byte_vector.
>
> FWIW, I gave this patch a careful read, and it looked sane to me.
> But I only consider myself a yellow-belt-C++-student, so a careful
> review from someone else would be useful too.
>
> As far as I can tell, the buildbots include ppc-aix, so the patch
> was tested there as well, so additional runs would probably not
> help, right? (I am pretty sure that the shared library code is
> exercised).
LGTM too, though in arm-tdep.c, I would suggest getting rid of the
exidx_size and extab_size variables, and to use the std::vector::size
instead.
Simon