This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 2/2] Use std::vector for field lists in dwarf2read.c


>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> I didn't spot anything wrong, just some nits.  The patch LGTM with
Simon> those fixed.

Thanks.  I'm appending the new patch.
I'm checking it in.

Simon> This comment is stale.
[...]
Simon> This one too.

I updated them a bit, but maybe not super well.  I was inclined to just
remove them but I didn't know how that would go over.

I can fix them up more somehow if you want.

Simon> Nit: If you remove the unnecessary braces here, you can avoid the
Simon> line wrapping.

It was 1 character too long for that but I removed the braces anyhow.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]