This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/3] Testsuite: Rename "end()" to avoid libinproctrace C++ symbol clash

From: Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
To: Simon Marchi <simon dot marchi at ericsson dot com>
Cc: <gdb-patches at sourceware dot org>
Date: Mon, 19 Mar 2018 13:15:09 +0100
Subject: Re: [PATCH 2/3] Testsuite: Rename "end()" to avoid libinproctrace C++ symbol clash
References: <1521043903-18837-1-git-send-email-arnez@linux.vnet.ibm.com> <1521043903-18837-3-git-send-email-arnez@linux.vnet.ibm.com> <5431d374-f1a4-65e0-82ee-a1758aa037a1@ericsson.com> <m3lgerx0oz.fsf@oc1027705133.ibm.com> <a31c0b89-dbcf-fb40-d8ec-aee748e61e3c@ericsson.com>

On Fri, Mar 16 2018, Simon Marchi wrote:

> Since the gdb_breakpoint proc accepts the multi-location printout, we may
> not even need the "qualified", just using gdb_breakpoint would be sufficient.
> But I think it's not bad either to use "qualified", as it makes the test more
> robust.  It makes sure the test doesn't stop on another random end function/method.

Right, these random breakpoints could hit us badly in the future.

> So this LGTM, thanks.

Thanks, pushed.

--
Andreas

References:
- [PATCH 0/3] Some gdbserver test suite fixes
  - From: Andreas Arnez
- [PATCH 2/3] Testsuite: Rename "end()" to avoid libinproctrace C++ symbol clash
  - From: Andreas Arnez
- Re: [PATCH 2/3] Testsuite: Rename "end()" to avoid libinproctrace C++ symbol clash
  - From: Simon Marchi
- Re: [PATCH 2/3] Testsuite: Rename "end()" to avoid libinproctrace C++ symbol clash
  - From: Andreas Arnez
- Re: [PATCH 2/3] Testsuite: Rename "end()" to avoid libinproctrace C++ symbol clash
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]