This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/3] S390: Enable re-attaching with native-extended-gdbserver

On Wed, Mar 21 2018, Simon Marchi wrote:

> I am just looking through this to have an idea of what's happening
> and found one nit:
>
>> +/* Determine the word size for the given PID, in bytes.  */
>> +
>> +#ifdef __s390x__
>> +static int
>> +s390_get_wordsize (int pid)
>> +{
>> +  errno = 0;
>> +  PTRACE_XFER_TYPE pswm = ptrace (PTRACE_PEEKUSER, pid,
>> +				  (PTRACE_TYPE_ARG3) 0,
>> +				  (PTRACE_TYPE_ARG4) 0);
>> +  if (errno != 0) {
>> +    warning (_("Couldn't determine word size, assuming 64-bit.\n"));
>> +    return 8;
>> +  }
>
> GNU-style curly braces.

Oops...

Thanks, pushed a fix.

--
Andreas
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]