This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v4 01/10] Move tdesc header funcs to c file

From: Simon Marchi <simon dot marchi at ericsson dot com>
To: <alan dot hayward at arm dot com>, <gdb-patches at sourceware dot org>
Cc: <nd at arm dot com>
Date: Thu, 22 Mar 2018 16:43:28 -0400
Subject: Re: [PATCH v4 01/10] Move tdesc header funcs to c file
References: <20180322084429.26250-1-alan.hayward@arm.com> <20180322084429.26250-2-alan.hayward@arm.com>
Spamdiagnosticmetadata: NSPM
Spamdiagnosticoutput: 1:99

On 2018-03-22 04:44 AM, alan.hayward@arm.com wrote:
> From: Alan Hayward <alan.hayward@arm.com>
> 
> Move the destructor and equals operator for gdbserver tdesc from the .h
> to the .c file. Both functions are too long to be inlined and make the
> header look messy. Patch does not change any functionality.
> Patch identical to V3 version.
> 
> 2018-03-21  Alan Hayward  <alan.hayward@arm.com>
> 
> gdbserver/
> 	* tdesc.c (target_desc::~target_desc): Move to here.
> 	(target_desc::operator==): Likewise.
> 	* tdesc.h (target_desc::~target_desc): Move from here.
> 	(target_desc::operator==): Likewise.

This patch LGTM, feel free to push it by itself, it will be one
less patch to worry about.

Simon

References:
- [PATCH v4 00/10] Remove gdbserver dependency on xml files
  - From: alan . hayward
- [PATCH v4 01/10] Move tdesc header funcs to c file
  - From: alan . hayward

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]