This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] Remove make_cleanup_unpush_target

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Tom Tromey <tom at tromey dot com>
Cc: gdb-patches at sourceware dot org
Date: Fri, 30 Mar 2018 12:10:40 -0400
Subject: Re: [RFA] Remove make_cleanup_unpush_target
References: <20180329152215.3783-1-tom@tromey.com>

On 2018-03-29 11:22, Tom Tromey wrote:

This removes make_cleanup_unpush_target, replacing it with a
unique_ptr.  This may seem odd, because the object in question is not
actually freed, but unique_ptr provided the necessary functionality.

Tested by the buildbot.

I was not sure about the usage of unique_ptr at first, but I guess itworks just as well as writing our own object. So it LGTM.


Simon

References:
- [RFA] Remove make_cleanup_unpush_target
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]