This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Change read_alphacoff_dynamic_symtab to use gdb::def_vector


On 2018-04-03 13:29, Tom Tromey wrote:
"Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> I am pretty sure that you could use gdb::byte_vector here and it
Simon> would be fine.

It needed one extra cast, but yeah.

Simon> Could you (if it's not too much trouble) remove the size
variables (sym_secsize and
Simon> friends)?  This way, there's only one source of truth for the
allocated size (the
Simon> vector size).  Also, the "ptr" suffix probably made sense when
the variables were
Simon> pointers.  It would make sense to rename them, sym_secptr ->
sym_sec, and so forth.

How's this?

Tom

LGTM, thanks!

Simon


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]