Re: [PATCH] infrun: step through indirect branch thunks

[Pedro Alves <palves at redhat dot com>]

On 04/09/2018 05:24 PM, Metzger, Markus T wrote:

> It is not the default.  I had to add a new function to return the default.  IIUC this
> is disabling INVALID_P checks to allow default_in_indirect_branch_thunk to be
> used as default.

Ah, yeah.

> 
> 
>>> +    gdb_test_multiple "stepi" "$test: stepi" {
>>> +        -re "$current.*$gdb_prompt $" {
>>> +            send_gdb "stepi\n"
>>> +            exp_continue
>>
>> This should probably have some upper bound.
> 
> Unless some compiler bug generated an infinite loop or GDB's stepping is
> completely broken, we should eventually step out of $current.

If nothing would ever break, we wouldn't need regression tests.  :-)

Keep developers doing local changes and breaking things routinely in
mind as well.

> I read your comment about an upper bound in your first reply but thought
> that it wouldn't be necessary.  Do you think we need one?

I do, because if for some reason the end up in the infinite loop, the
testcase will never timeout, hanging the test run.

Thanks,
Pedro Alves