Re: [PATCH v3 2/5] Copy string_view files from libstdc++

[Pedro Alves <palves at redhat dot com>]

On 04/09/2018 06:23 PM, Simon Marchi wrote:
> On 2018-04-09 09:44, Pedro Alves wrote:
>> On 04/07/2018 02:26 PM, Simon Marchi wrote:
>>
>>> This patch copies the following files from libstdc++ (commit
>>> 02a4441f002c):
>>>
>>>   ${gcc}/include/std/string_view -> ${binutils-gdb}/gdb/common/gdb_string_view.h
>>>   ${gcc}/include/bits/string_view.tcc -> ${binutils-gdb}/gdb/common/gdb_string_view.tcc
>>
>> Nit: the source filenames here should be updated.  Maybe commit as
>> well, if applicable.
> 
> Oops, I'm missing "libstdc++-v3" in the source names.  Is there anything else wrong with the paths?  What about the commit?

That too, but I was actually thinking that the files in this revision were
copied from:

 include/experimental/string_view
 include/experimental/bits/string_view.tcc

instead?

The commit looks fine.

Thanks,
Pedro Alves