This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add selftests for range_contains and insert_into_bit_range_vector

From: Pedro Alves <palves at redhat dot com>
To: Simon Marchi <simon dot marchi at ericsson dot com>, Simon Marchi <simon dot marchi at polymtl dot ca>, gdb-patches at sourceware dot org
Date: Mon, 9 Apr 2018 20:35:28 +0100
Subject: Re: [PATCH] Add selftests for range_contains and insert_into_bit_range_vector
References: <20180407143801.19596-1-simon.marchi@polymtl.ca> <a75743b5-007c-de9e-bc07-058e7845fef9@redhat.com> <09d2a032-8726-6351-ab9a-63574734a3e5@ericsson.com>

On 04/09/2018 08:01 PM, Simon Marchi wrote:
> On 2018-04-07 02:33 PM, Pedro Alves wrote:
>> See patch below on top of yours implementing most of the suggestions
>> above, except the missing comments.
>>
>> WDYT?
> 
> I agree with all your suggested changes.  Here is the merged patch I would push.
> I also changed "test_range_contains" to "test_ranges_contain" to match the name
> of the function.

Thanks, please push.

Pedro Alves

Follow-Ups:
- Re: [PATCH] Add selftests for range_contains and insert_into_bit_range_vector
  - From: Simon Marchi

References:
- [PATCH] Add selftests for range_contains and insert_into_bit_range_vector
  - From: Simon Marchi
- Re: [PATCH] Add selftests for range_contains and insert_into_bit_range_vector
  - From: Pedro Alves
- Re: [PATCH] Add selftests for range_contains and insert_into_bit_range_vector
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]