This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 05/15] Fix elf_gnu_ifunc_resolve_by_got buglet
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simark at simark dot ca>, gdb-patches at sourceware dot org
- Date: Tue, 10 Apr 2018 22:52:36 +0100
- Subject: Re: [PATCH v2 05/15] Fix elf_gnu_ifunc_resolve_by_got buglet
- References: <20180325191943.8246-1-palves@redhat.com> <20180325191943.8246-6-palves@redhat.com> <65e568e8-ef50-0119-27ec-053849592706@simark.ca>
On 04/01/2018 05:32 AM, Simon Marchi wrote:
> On 2018-03-25 03:19 PM, Pedro Alves wrote:
>> --- a/gdb/elfread.c
>> +++ b/gdb/elfread.c
>> @@ -840,10 +840,12 @@ elf_gnu_ifunc_resolve_by_got (const char *name, CORE_ADDR *addr_p)
>> ¤t_target);
>> addr = gdbarch_addr_bits_remove (gdbarch, addr);
>>
>> - if (addr_p)
>> - *addr_p = addr;
>> if (elf_gnu_ifunc_record_cache (name, addr))
>> - return 1;
>> + {
>> + if (addr_p)
>
> addr_p != NULL ?
>
Might as well. I've done that locally.
Thanks,
Pedro Alves