This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA 2/2] Set TYPE_NAME for Rust unions


> I think that TYPE_TAG_NAME is confusing and should probably be
> removed.  I am working on a patch to do this, but in the meantime this
> seemed like a reasonable change to apply.  I suspect this change would
> be ok for C++ as well, but I do not know about D.

I agree that TYPE_TAG_NAME is confusing, and I would welcome it being
removed.

> 2018-04-12  Tom Tromey  <tom@tromey.com>
> 
> 	* dwarf2read.c (read_structure_type): Set TYPE_NAME for rust
> 	unions.

The patch looks good to me, but I'd like to see if others have comments
about C++. I'm trying to remember if C++ enums might have different
rules compared to C enums, and I'm not remembering any... If there
weren't any difference, and things were OK with C enums, one might
think that we're OK for C++ enums as well...

No way to test this either?

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]