This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Fix crash in quirk_rust_enum
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Tue, 17 Apr 2018 17:10:32 +0100
- Subject: Re: [RFA] Fix crash in quirk_rust_enum
- References: <20180329175126.30863-1-tom@tromey.com>
On 03/29/2018 06:51 PM, Tom Tromey wrote:
> I noticed that quirk_rust_enum can crash when presented with a union
> whose fields are all scalar types.
>
> This patch adds a new test case and fixes the bug.
>
> Regression tested on Fedora 26 x86-64.
Even though the code your touching is in dwarf2read.c, it is
Rust-only code, so IMHO you should be able to self-approve it.
I have nothing really useful to say about the change.
Mechanically, looks fine to me.
Thanks,
Pedro Alves