This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 2/2] Set TYPE_NAME for Rust unions

From: Tom Tromey <tom at tromey dot com>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Tue, 17 Apr 2018 13:37:07 -0600
Subject: Re: [RFA 2/2] Set TYPE_NAME for Rust unions
References: <20180412190756.16052-1-tom@tromey.com> <20180412190756.16052-3-tom@tromey.com> <20180413074052.lxdfiypb3kq6ulp3@adacore.com>

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

>> 2018-04-12  Tom Tromey  <tom@tromey.com>
>> 
>> * dwarf2read.c (read_structure_type): Set TYPE_NAME for rust
>> unions.

Joel> The patch looks good to me, but I'd like to see if others have comments
Joel> about C++. I'm trying to remember if C++ enums might have different
Joel> rules compared to C enums, and I'm not remembering any... If there
Joel> weren't any difference, and things were OK with C enums, one might
Joel> think that we're OK for C++ enums as well...

Joel> No way to test this either?

I am not sure.  However, my TYPE_TAG_NAME deletion patch is ready now
(I'll send it momentarily), so I think we can just drop this one,
because that patch obsoletes it.

Tom

References:
- [RFA 0/2] Minor Rust-related DWARF reader fixes
  - From: Tom Tromey
- [RFA 2/2] Set TYPE_NAME for Rust unions
  - From: Tom Tromey
- Re: [RFA 2/2] Set TYPE_NAME for Rust unions
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]