This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v5 4/8] Add tdesc osabi and architecture functions
Hi Alan,
Just a nit:
On 2018-04-10 10:33 AM, Alan Hayward wrote:
> diff --git a/gdb/common/tdesc.h b/gdb/common/tdesc.h
> index 7f4222b653..311341da0d 100644
> --- a/gdb/common/tdesc.h
> +++ b/gdb/common/tdesc.h
> @@ -297,9 +297,18 @@ target_desc *allocate_target_description (void);
> void set_tdesc_architecture (target_desc *target_desc,
> const char *name);
>
> +/* Return the architecture associated with this target description as a string,
> + or NULL if no architecture was specified. */
> +const char *tdesc_architecture_name (const struct target_desc *target_desc);
> +
> /* Set TARGET_DESC's osabi by NAME. */
> void set_tdesc_osabi (target_desc *target_desc, const char *name);
>
> +/* Return the osabi associated with this target description as a string,
> + or NULL if no osabi was specified. */
> +const char *
> +tdesc_osabi_name (const struct target_desc *target_desc);
Remove the \n before the function name.
Simon