Re: [PATCH 31/40] target_ops/C++: Base FreeBSD target

[Pedro Alves <palves at redhat dot com>]

On 04/18/2018 12:21 PM, Pedro Alves wrote:
> On 04/18/2018 01:37 AM, John Baldwin wrote:

>> I've pushed a target_ops-cxx branch to github.com/bsdjhb/gdb.git that has
>> some small fixups (compile fixes).  
> 
> Thank you!

I've now merged/squashed those fixes to the patches in the branch,
and added your name to the WIP ChangeLog entry.

I diff my branch against yours to double-checked whether I was
missing anything, then rebased on top of current master.

I force-pushed the result to users/palves/target_ops-cxx on sourceware.org.

Thanks again.

> There's a small set of target methods that must always be
> implemented by native targets, to avoid falling down to the
> target beneath (since the target may not be pushed when the
> method is called).  See target.c:complete_target_initialization
> in current master.  Since all native targets inherit from inf-child
> (just like in current master), in the C++ version, we can override
> it there.  Like below.  This fixes it for me.
> 
> diff --git c/gdb/inf-child.h w/gdb/inf-child.h
> index d3f8b71589..956cee2a0a 100644
> --- c/gdb/inf-child.h
> +++ w/gdb/inf-child.h
> @@ -72,6 +72,7 @@ public:
>       target that can run.  */
>    bool can_async_p ()  override { return false; }
>    bool supports_non_stop ()  override { return false; }
> +  bool supports_disable_randomization () override { return false; }
>  
>    char *pid_to_exec_file (int pid) override;

This is in the branch too now.

Thanks,
Pedro Alves