This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: possible fix for PR symtab/23010

From: Tom Tromey <tom at tromey dot com>
To: Keith Seitz <keiths at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Thu, 19 Apr 2018 14:39:31 -0600
Subject: Re: possible fix for PR symtab/23010
References: <87po34kzxh.fsf@tromey.com> <f163fa84-eb60-ac12-dedb-b6970b799165@redhat.com>

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> I tried for darn near a week to come up with an isolated
Keith> reproducer to no avail. :-(

If you have a test case, could you send it, even it if doesn't work?
I could try to poke at it a little.

Keith> Aside: didn't we decide that "update all callers" was sufficient? [I'm
Keith> only curious -- not asking for changes to a silly ChangeLog.]

Yeah, old habits I guess.

Keith> This patch looks reasonable to me, but I would ask you to consider
Keith> mentioning why partial_units are skipped where they are (even if to
Keith> just reference the problem or bug?). That's these two hunks, I think:

Good idea, will do.

Tom

References:
- possible fix for PR symtab/23010
  - From: Tom Tromey
- Re: possible fix for PR symtab/23010
  - From: Keith Seitz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]