This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: ping: [patch] aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones
- From: Pedro Alves <palves at redhat dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: jan dot kratochvil at redhat dot com, qiyaoltc at gmail dot com, gdb-patches at sourceware dot org
- Date: Fri, 20 Apr 2018 16:59:50 +0100
- Subject: Re: ping: [patch] aarch64: PR 19806: watchpoints: false negatives + PR 20207 contiguous ones
- References: <20170327210753.GA29656@host1.jankratochvil.net> <20171018195237.GA19714@host1.jankratochvil.net> <867evczxik.fsf@gmail.com> <20171103220437.GA13979@host1.jankratochvil.net> <20180321190316.GA32598@host1.jankratochvil.net> <1e06eb53-60f4-0800-a4f6-458e02f840bd@redhat.com> <83po2tyiu0.fsf@gnu.org>
On 04/20/2018 04:54 PM, Eli Zaretskii wrote:
>> diff --git a/gdb/NEWS b/gdb/NEWS
>> index 25c404bfc37..38043c4ff2e 100644
>> --- a/gdb/NEWS
>> +++ b/gdb/NEWS
>> @@ -35,6 +35,16 @@ SH-5/SH64 ELF sh64-*-elf*, SH-5/SH64 support in sh*
>> SH-5/SH64 running GNU/Linux SH-5/SH64 support in sh*-*-linux*
>> SH-5/SH64 running OpenBSD SH-5/SH64 support in sh*-*-openbsd*
>>
>> +* Aarch64/Linux hardware watchpoints improvements
>> +
>> + Hardware watchpoints on unaligned addresses are now properly
>> + supported when running Linux kernel 4.10 or higher: read and access
>> + watchpoints are no longer spuriously missed, and all watchpoints
>> + lengths between 1 and 8 bytes are supported. On older kernels,
>> + watchpoints set on unaligned addresses are no longer missed, with
>> + the tradeoff that there is a possibility of false hits being
>> + reported.
>
> I wonder whether we need this NEWS entry. We don't normally call out
> bugfixes there, do we?
Yao requested one in an earlier review. I'm borderline about it
myself, with no strong opinion.
There's a tradeoff here, which may be worth advertising, and the
mention of kernel version might be useful too.
Thanks,
Pedro Alves