This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA 0/9] Enable -Wimplicit-fallthrough
- From: Tom Tromey <tom at tromey dot com>
- To: gdb-patches at sourceware dot org
- Date: Sat, 21 Apr 2018 12:30:47 -0600
- Subject: [RFA 0/9] Enable -Wimplicit-fallthrough
This series enables -Wimplicit-fallthrough for gdb. I think this is
valuable because it can prevent the occasional bug.
A couple of the patches are straightforward. For example, patch #1
changes existing "fall-through" comments to the correct form that will
be recognized by GCC.
In some cases I was not sure which change to make. I've split all
these out in this series for easier review. Please examine them
carefully. This applies to patches 4, 5, 6, and 8.
I chose to use comments rather than the new fall-through attribute
because the comments are more portable: they can be ignored by
compilers that do not understand them, and they do not require
additional configury.
Tested by the buildbot.
Tom