This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 3/8] Make print_command_trace varargs

From: Pedro Alves <palves at redhat dot com>
To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Tue, 24 Apr 2018 17:43:15 +0100
Subject: Re: [RFA 3/8] Make print_command_trace varargs
References: <20180419191539.661-1-tom@tromey.com> <20180419191539.661-4-tom@tromey.com>

On 04/19/2018 08:15 PM, Tom Tromey wrote:
> I noticed some code in execute_control_command_1 that could be
> simplified by making print_command_trace a printf-like function.  This
> patch makes this change.
> 
> 2018-04-19  Tom Tromey  <tom@tromey.com>
> 
> 	* top.c (execute_command): Update.
> 	* cli/cli-script.h (print_command_lines): Now varargs.
> 	* cli/cli-script.c (print_command_lines): Now varargs.
> 	(execute_control_command_1) <case while_control, case if_control>:
> 	Update.

Looks fine to me.

Thanks,
Pedro Alves

References:
- [RFA 0/8] Various command-related improvements
  - From: Tom Tromey
- [RFA 3/8] Make print_command_trace varargs
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]