This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 2/8] Use counted_command_line everywhere

From: Tom Tromey <tom at tromey dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Tue, 24 Apr 2018 17:18:48 -0600
Subject: Re: [RFA 2/8] Use counted_command_line everywhere
References: <20180419191539.661-1-tom@tromey.com> <20180419191539.661-3-tom@tromey.com> <ea99b3d5-3d82-c30f-1730-e05bf5f1a1b6@redhat.com>

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

>> +      gdb::unique_xmalloc_ptr<char> default_collect_line
>> +	(xstrprintf ("collect %s", default_collect));

Pedro> string_printf ?

Actually, a few lines later:

>> +      actions.reset (new struct command_line (simple_control,
>> +					      default_collect_line.release ()),

So this couldn't use string_printf without additional work.

Tom

References:
- [RFA 0/8] Various command-related improvements
  - From: Tom Tromey
- [RFA 2/8] Use counted_command_line everywhere
  - From: Tom Tromey
- Re: [RFA 2/8] Use counted_command_line everywhere
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]