This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Eliminate target_ops::to_xclose
- From: Tom Tromey <tom at tromey dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 27 Apr 2018 09:24:30 -0600
- Subject: Re: [PATCH] Eliminate target_ops::to_xclose
- References: <20180413175700.19109-1-palves@redhat.com>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> In the multi-target branch, I found no need for the target_close vs
Pedro> target_xclose distinction. Heap-allocated targets simply delete
Pedro> themselves in their target_close implementation, while
Pedro> singleton/static targets don't.
Pedro> The target_ops C++ification patches will add more commentary around
Pedro> target_ops's destructor, but there's no destructor yet...
This looks good to me and it seems like the close/xclose distinction
already doesn't really make sense anyway.
Tom