This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Enable -Wsuggest-override
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Fri, 27 Apr 2018 19:07:27 +0100
- Subject: Re: [RFA] Enable -Wsuggest-override
- References: <20180427140734.8540-1-tom@tromey.com>
On 04/27/2018 03:07 PM, Tom Tromey wrote:
> I noticed the existence of -Wsuggest-override and so this patch
> enables it for gdb. It found a few spots that could use "override".
> Also I went ahead and removed all uses of the "OVERRIDE" macro.
>
> Using override is beneficial because it makes it harder to change a
> base class and then forget to change a derived class.
>
> Tested by the buildbot.
Yes, please. OK.
Thanks,
Pedro Alves