This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 00/40] C++ify target_ops, toward multi-target
- From: Simon Marchi <simark at simark dot ca>
- To: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
- Date: Sun, 29 Apr 2018 11:22:09 -0400
- Subject: Re: [PATCH 00/40] C++ify target_ops, toward multi-target
- References: <20180414190953.24481-1-palves@redhat.com>
On 2018-04-14 03:09 PM, Pedro Alves wrote:
> Here's another chunk from the multi-target branch.
Hi Pedro,
It's kind of difficult to properly review this series, because the important
non-mechanical bits are lost in a sea of mechanical changes. But I didn't
find anything fundamental I would change, and all you wrote in commit logs
made sense to me.
Maybe one little comment about 40/40 (because I just finished looking at that
patch): it might be good to add an assertion (the_native_target == nullptr)
in set_native_target and one in add_target
(target_factories.find (&t) == target_factories.end ()). I think it could
help catch problems if somebody is trying to add a new target or change
existing ones.
Otherwise, I would suggest not waiting too long before merging it to
avoid having to resolve too many conflicts. Thanks a lot for doing this!
Simon