This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Add basic Python API for convenience variables
- From: Phil Muldoon <pmuldoon at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Mon, 30 Apr 2018 14:11:37 +0100
- Subject: Re: [RFA] Add basic Python API for convenience variables
- References: <20180422211309.31251-1-tom@tromey.com>
On 22/04/18 22:13, Tom Tromey wrote:
> This adds a basic Python API for accessing convenience variables.
> With this, convenience variables can be read and set from Python.
> Although gdb supports convenience variables whose value changes at
> each call, this is not exposed to Python; it could be, but I think
> it's just as good to write a convenience function in this situation.
>
>
> @findex gdb.find_pc_line
> diff --git a/gdb/python/py-value.c b/gdb/python/py-value.c
> index bba6d0b8a4..30a0082da8 100644
> --- a/gdb/python/py-value.c
> +++ b/gdb/python/py-value.c
> @@ -1746,6 +1746,83 @@ gdbpy_history (PyObject *self, PyObject *args)
> return value_to_value_object (res_val);
> }
>
> +/* Return the value of a convenience variable. */
> +PyObject *
> +gdbpy_convenience_variable (PyObject *self, PyObject *args)
> +{
> + const char *varname;
> + struct value *res_val = NULL;
> +
> + if (!PyArg_ParseTuple (args, "s", &varname))
> + return NULL;
> +
> + TRY
> + {
> + struct internalvar *var = lookup_only_internalvar (varname);
> +
> + if (var != NULL)
> + {
> + res_val = value_of_internalvar (python_gdbarch, var);
> + if (TYPE_CODE (value_type (res_val)) == TYPE_CODE_VOID)
> + res_val = NULL;
> + }
> + }
> + CATCH (except, RETURN_MASK_ALL)
> + {
> + GDB_PY_HANDLE_EXCEPTION (except);
> + }
> + END_CATCH
> +
> + if (res_val == NULL)
> + Py_RETURN_NONE;
> +
> + return value_to_value_object (res_val);
> +}
> +
> +/* Set the value of a convenience variable. */
> +PyObject *
> +gdbpy_set_convenience_variable (PyObject *self, PyObject *args)
> +{
> + const char *varname;
> + PyObject *value_obj;
> + struct value *value = NULL;
> +
> + if (!PyArg_ParseTuple (args, "sO", &varname, &value_obj))
> + return NULL;
> +
> + /* None means to clear the variable. */
> + if (value_obj != Py_None)
> + {
> + value = convert_value_from_python (value_obj);
> + if (value == NULL)
> + return NULL;
> + }
> +
> + TRY
> + {
> + if (value == NULL)
> + {
> + struct internalvar *var = lookup_only_internalvar (varname);
> +
> + if (var != NULL)
> + clear_internalvar (var);
> + }
> + else
> + {
> + struct internalvar *var = lookup_internalvar (varname);
> +
> + set_internalvar (var, value);
> + }
> + }
> + CATCH (except, RETURN_MASK_ALL)
> + {
> + GDB_PY_HANDLE_EXCEPTION (except);
> + }
> + END_CATCH
> +
> + Py_RETURN_NONE;
> +}
> +
I've read the patch and it LGTM.
Cheers
Phil