This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 4/4] Change Python code to use new_reference

From: Phil Muldoon <pmuldoon at redhat dot com>
To: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Mon, 30 Apr 2018 14:34:20 +0100
Subject: Re: [RFA 4/4] Change Python code to use new_reference
References: <20180430042147.28337-1-tom@tromey.com> <20180430042147.28337-5-tom@tromey.com>

On 30/04/18 05:21, Tom Tromey wrote:
> his changes a few spots in the Python code to use new_reference
> rather than the manual incref+constructor that was previously being
> done.
> 
> 2018-04-29  Tom Tromey  <tom@tromey.com>
> 
> 	* varobj.c (varobj_set_visualizer): Use new_reference.
> 	* python/python.c (gdbpy_decode_line): Use new_reference.
> 	* python/py-cmd.c (cmdpy_function, cmdpy_completer_helper): Use
> 	new_reference.
> ---

The Python related changes are largely mechanical in nature but just wanted to note LGTM.

Cheers

Phil

References:
- [RFA 0/4] add ref_ptr::new_reference
  - From: Tom Tromey
- [RFA 4/4] Change Python code to use new_reference
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]