This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA v2 7/8] Allow breakpoint commands to be set from Python

From: Tom Tromey <tom at tromey dot com>
To: Phil Muldoon <pmuldoon at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Mon, 30 Apr 2018 08:40:01 -0600
Subject: Re: [RFA v2 7/8] Allow breakpoint commands to be set from Python
References: <20180425154133.3989-1-tom@tromey.com> <20180425154133.3989-8-tom@tromey.com> <2e135d0d-4bb7-49f7-7397-71e656fd4d57@redhat.com>

Phil> The code bits LGTM but on a somewhat side note I'm wondering if there
Phil> are any side effects with the Python breakpoint stop callback? This
Phil> shouldn't interfere with the viability of this patch, though, because
Phil> a breakpoint previously could have had a command list attached to it
Phil> after being created in Python and via the commands command. I'm mildly
Phil> curious what would get called first.

The stop method is called first and the commands are only run if stop
returns True.  There's no conflict between the two.

Tom

References:
- [RFA v2 0/8] Various command-related improvements
  - From: Tom Tromey
- [RFA v2 7/8] Allow breakpoint commands to be set from Python
  - From: Tom Tromey
- Re: [RFA v2 7/8] Allow breakpoint commands to be set from Python
  - From: Phil Muldoon

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]