This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Eliminate procfs.c:procfs_use_watchpoints
- From: Pedro Alves <palves at redhat dot com>
- To: GDB Patches <gdb-patches at sourceware dot org>
- Date: Thu, 3 May 2018 00:57:34 +0100
- Subject: Re: [PATCH] Eliminate procfs.c:procfs_use_watchpoints
- References: <20180412165743.27235-1-palves@redhat.com>
On 04/12/2018 05:57 PM, Pedro Alves wrote:
> Now that procfs.c is only ever used by Solaris, and, both x86 and
> SPARC Solaris support watchpoints (*), we don't need the separate
> procfs_use_watchpoints function. Getting rid of it simplifies
> C++ification of target_ops.
>
> (*) and I assume that any other Solaris port would use the same kernel
> debug API interfaces for watchpoints. Otherwise, we can worry about
> it if it ever happens.
>
> gdb/ChangeLog:
> yyyy-mm-dd Pedro Alves <palves@redhat.com>
>
> * procfs.c (procfs_stopped_by_watchpoint)
> (procfs_insert_watchpoint, procfs_remove_watchpoint)
> (procfs_region_ok_for_hw_watchpoint, procfs_stopped_data_address):
> Forward declare.
> (procfs_use_watchpoints): Delete, move contents...
> (procfs_target): ... here.
> * procfs.h (procfs_use_watchpoints): Delete declaration.
> * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Don't call
> procfs_use_watchpoints.
> * sparc-sol2-nat.c (_initialize_sparc_sol2_nat): Don't call
> procfs_use_watchpoints.
I pushed this in.
Thanks,
Pedro Alves