This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Eliminate target_ops::to_xclose
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 3 May 2018 00:59:58 +0100
- Subject: Re: [PATCH] Eliminate target_ops::to_xclose
- References: <20180413175700.19109-1-palves@redhat.com> <87muxo65ap.fsf@tromey.com>
On 04/27/2018 04:24 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> In the multi-target branch, I found no need for the target_close vs
> Pedro> target_xclose distinction. Heap-allocated targets simply delete
> Pedro> themselves in their target_close implementation, while
> Pedro> singleton/static targets don't.
>
> Pedro> The target_ops C++ification patches will add more commentary around
> Pedro> target_ops's destructor, but there's no destructor yet...
>
> This looks good to me and it seems like the close/xclose distinction
> already doesn't really make sense anyway.
Thanks for taking a look Tom. I've merged it.
Thanks,
Pedro Alves