This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/3] gdb/testsuite: Fix broken regexp in gdbstub case
- From: Pedro Alves <palves at redhat dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 4 May 2018 10:18:05 +0100
- Subject: Re: [PATCH 1/3] gdb/testsuite: Fix broken regexp in gdbstub case
- References: <cover.1523286728.git.andrew.burgess@embecosm.com> <1ec70ce9afe8bebbb3f0257778943d4634ea126b.1523286728.git.andrew.burgess@embecosm.com> <092e44fd-096b-e96b-542b-a8eb4c5c5f1d@redhat.com> <20180503194115.GJ3375@embecosm.com>
On 05/03/2018 08:41 PM, Andrew Burgess wrote:
> * Pedro Alves <palves@redhat.com> [2018-04-13 13:12:30 +0100]:
>
>> On 04/09/2018 04:15 PM, Andrew Burgess wrote:
>>> When $use_gdb_stub is true then, when we start an MI target there's a
>>> regexp to match GDB's startup pattern. Unfortunately the pattern is
>>> broken, and we're also missing a timeout case in the match list (which
>>> would have helped point out that the regexp was broken).
>>
>> That seems to have been added by:
>> https://sourceware.org/ml/gdb-patches/2015-12/msg00357.html
>>
>> curious how it seems to have worked back then. I wonder whether
>> it was GDB's CLI-in-MI output that changed meanwhile?
>>
>> I'd have appreciated a bit more detail on what is actually broken in
>> the pattern. The git log above gives no clue, and the diff is not
>> exactly easy to read. I trust that it's now correct though. Thus, OK.
>
> I aim to please,
:-)
> so here's a revised commit message detailing what
> changed. The actual patch content hasn't changed. I'll wait a few
> days, but if I don't hear anything I'll assume your approval above
> still stands and apply the patch.
Perfect. This is OK.
Thanks,
Pedro Alves