This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 3/3] Heap-allocate core_target instances

From: Tom Tromey <tom at tromey dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Mon, 07 May 2018 08:26:17 -0600
Subject: Re: [PATCH 3/3] Heap-allocate core_target instances
References: <20180503162234.15371-1-palves@redhat.com> <20180503162234.15371-4-palves@redhat.com> <87in832x9t.fsf@tromey.com> <889a13d0-e1c1-02a8-fd99-cdf872e214e7@redhat.com>

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> It seems OK to me.  The core_target::detach case might be less
Pedro> obvious?  I'm adding some comments.

Thanks.

Pedro> Let me know what you think of this version.

Looks reasonable to me, thanks.

Tom

Follow-Ups:
- Re: [PATCH 3/3] Heap-allocate core_target instances
  - From: Pedro Alves

References:
- [PATCH 0/3] Torward multiple simultaneous core instances
  - From: Pedro Alves
- [PATCH 3/3] Heap-allocate core_target instances
  - From: Pedro Alves
- Re: [PATCH 3/3] Heap-allocate core_target instances
  - From: Tom Tromey
- Re: [PATCH 3/3] Heap-allocate core_target instances
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]