This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 1/2] Fix decoding of ARM VFP instructions
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tom at tromey dot com>, Omair Javaid <omair dot javaid at linaro dot org>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Mon, 7 May 2018 15:35:24 +0100
- Subject: Re: [RFA 1/2] Fix decoding of ARM VFP instructions
- References: <20180421214721.7232-1-tom@tromey.com> <20180421214721.7232-2-tom@tromey.com> <CANW4E-0qnudezdKcWH+c64AUbK-LUjWanbgCuuHFUTGBSeT2sg@mail.gmail.com> <87a7tf2vwf.fsf@tromey.com>
On 05/04/2018 06:06 PM, Tom Tromey wrote:
>>>>>> "Omair" == Omair Javaid <omair.javaid@linaro.org> writes:
>
>>> On 22 April 2018 at 02:47, Tom Tromey <tom@tromey.com> wrote:
>>> -Wduplicated-cond pointed out that arm_record_vfp_data_proc_insn
>>> checks "opc1 == 0x0b" twice. I filed this a while ago as
>>> PR tdep/20362.
>>>
>>> Based on the ARM instruction manual at
>>> https://www.scss.tcd.ie/~waldroj/3d1/arm_arm.pdf, I think the
>>> instruction decoding in this function has two bugs.
> [...]
>
> Omair> Seems LGTM. Let me get back to you after running testsuite for regressions.
>
> Did this work out?
FAOD, this is OK if there are no regressions.
Thanks,
Pedro Alves