On 05/04/2018 05:55 PM, Joel Brobecker wrote:
What worries me is that I don't see what's preventing us from hitting
that issue outside of the unittests code? We know we can adjust our
own classes, but this problem occured with a system class, so we had
no choice but to use GNULIB_NAMESPACE. I worry that the transition
from no GNULIB_NAMESPACE to using GNULIB_NAMESPACE in a given unit
will leave some C system calls that should normally be covered by
gnulib silently now reverting to the system (buggy) version.
Note that this is what led me to work on the whole wild/full matching
for C++, the TAB improvements, etc. See:
https://sourceware.org/ml/gdb-patches/2017-06/msg00012.html
I haven't rebased/updated the cxx-gdb-namespace branch since, as
I assumed it prudent to wait some time after a gdb is released
with support for wildmatching. That has happened, so maybe we can
consider going through with wrapping all of gdb in a namespace?
Or is it still too soon?
Thanks,
Pedro Alves