This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH RFC 4/5] Introduce scoped_mmapped_file

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simon dot marchi at polymtl dot ca>
Cc: Tom Tromey <tom at tromey dot com>, Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
Date: Fri, 11 May 2018 21:53:28 -0600
Subject: Re: [PATCH RFC 4/5] Introduce scoped_mmapped_file
References: <1525901216-15031-1-git-send-email-simon.marchi@ericsson.com> <1525901216-15031-5-git-send-email-simon.marchi@ericsson.com> <87y3grz0px.fsf@tromey.com> <1601635db4edc8926dfcf2a82db65c3e@polymtl.ca>

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

>> ... however, then I thought perhaps this question could be avoided by
>> just initializing m_fd directly, like:
>> 
>> scoped_mmapped_file (const char *filename)
>> : m_fd (open (filename, 0, O_RDONLY))
>> 
>> Then "reset" wouldn't be needed at all.

Simon> I can do that, but I am using reset() in the following patch anyway.

Oops, I didn't notice that.  FWIW I think it's fine to have a reset
method.

Tom

References:
- [PATCH RFC 0/5] Add a DWARF index cache
  - From: Simon Marchi
- [PATCH RFC 4/5] Introduce scoped_mmapped_file
  - From: Simon Marchi
- Re: [PATCH RFC 4/5] Introduce scoped_mmapped_file
  - From: Tom Tromey
- Re: [PATCH RFC 4/5] Introduce scoped_mmapped_file
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]